Add JWT in auth header as an authN option#325
Merged
AllenAnthes merged 1 commit intomasterfrom Jun 19, 2020
Merged
Conversation
aaron-junot
force-pushed
the
jwt-auth
branch
4 times, most recently
from
ba0bfc9 to
d440f92
Compare
Member
Author
|
@AllenAnthes I think I got a bunch of good test cases. I filled in some areas that were lacking validation and certain error cases are handled better now. I think we're just about there. Please give it a good shake and we should be ready to merge |
aaron-junot
commented
Jun 18, 2020
|
|
||
| # Usage: make test-single tests/unit/test_api_key.py::test_get_api_key | ||
| .PHONY: test-single | ||
| test-single: build |
Member
Author
There was a problem hiding this comment.
This has nothing to do with this PR in particular, I just realized it was useful and wanted to use it
This was referenced Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JWT as an authentication option (this is how the Resources page will authenticate).